Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15140 )
Change subject: IMPALA-9348: Add flag to disable column masking ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15140/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15140/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@282 PS2, Line 282: if (!isColumnMaskingEnabled_ > Ignore this as I understand that you are reverting to the pre-IMPALA-9009 b Thanks! But we can exit sooner if the flag is True by moving "!isColumnMaskingEnabled_" to the caller to avoid 100 function calls. -- To view, visit http://gerrit.cloudera.org:8080/15140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7c98042cfb831ba00d9d2179367cba257b77a0 Gerrit-Change-Number: 15140 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 31 Jan 2020 05:13:54 +0000 Gerrit-HasComments: Yes
