Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15140 )
Change subject: IMPALA-9348: Add flag to disable column masking ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15140/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15140/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@285 PS3, Line 285: "Column masking is disabled by --enable_column_masking flag. Can't access " + Thanks for making the change to avoid unnecessary function calls. One minor nit: This error message says 'Column masking is disabled by ...' but this assumes that the caller is always calling this function when the flag is false. Another caller could potentially call this function even when the flag is true. Anyways, this is ok for now since I understand the disabling is a temporary thing until the feature is fully tested. -- To view, visit http://gerrit.cloudera.org:8080/15140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7c98042cfb831ba00d9d2179367cba257b77a0 Gerrit-Change-Number: 15140 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 31 Jan 2020 06:06:55 +0000 Gerrit-HasComments: Yes