Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15140 )
Change subject: IMPALA-9348: Add flag to disable column masking ...................................................................... Patch Set 5: (2 comments) Thanks Aman and Csaba for looking into this so quickly! http://gerrit.cloudera.org:8080/#/c/15140/4/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15140/4/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@228 PS4, Line 228: Also deny access of columns : // containing column masking policies when column masking feature is disabled. > I would prefer to mention this in the commit message. Done http://gerrit.cloudera.org:8080/#/c/15140/4/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15140/4/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@200 PS4, Line 200: authorizeRowFilter(user, > The same condition is already checked in the previous line. Oops, done. -- To view, visit http://gerrit.cloudera.org:8080/15140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife7c98042cfb831ba00d9d2179367cba257b77a0 Gerrit-Change-Number: 15140 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 31 Jan 2020 10:14:10 +0000 Gerrit-HasComments: Yes
