Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only ...................................................................... Patch Set 2: (5 comments) Thanks for the change. This looks good. In the Jira Lars says "As a permanent solution we should only emit a warning when the socket cannot be found and -is_executor=false". This solution is different in that it just avoids the check. That is probably OK but can you explain why you're not doing what Lars said. http://gerrit.cloudera.org:8080/#/c/15173/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15173/2//COMMIT_MSG@10 PS2, Line 10: DataNode is not avaiable on the hosts. This change adds a condition to Nit: typo: available http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@723 PS2, Line 723: if (!BackendConfig.INSTANCE.getBackendCfg().is_executor) { Should this check move after the test for DFS_CLIENT_READ_SHORTCIRCUIT_KEY? If short-circuit reads are not enabled then this message might be confusing? http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@724 PS2, Line 724: LOG.info("Coordinator only instance will not read local data via " + Nit "Coordinator-only" is clearer I think http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@725 PS2, Line 725: "short-circuit reads."); We use clang-format to format Java code (as well as C++) https://cwiki.apache.org/confluence/display/IMPALA/Impala+Style+Guide You can get a plugin for IntelliJ which makes it easy to do. It finds a few small nits in your code layout. http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@68 PS2, Line 68: // GIVEN I wasn't familiar with this given-when-then style but I googled it and learned something. As I'm not used to it I found it a little jarring as this is the only use of it I have seen in the Impala codebase -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Feb 2020 18:55:23 +0000 Gerrit-HasComments: Yes
