Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode ...................................................................... Patch Set 3: Code-Review+1 (1 comment) LGTM. Okay for Andrew to +2 after code style nit is addressed. http://gerrit.cloudera.org:8080/#/c/15173/3/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/15173/3/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@79 PS3, Line 79: Line 79 and 80 should have 4 space indent. I know these can be difficult to catch but the best way is to teach the IDE . You can use something like https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml and modify it to comply with our guidelines. (I only had to change line wrap at 90.) If I'm unsure, I usually look at the surrounding code and follow that style. -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Feb 2020 02:30:39 +0000 Gerrit-HasComments: Yes