Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh@41 PS3, Line 41: # Parametrized Test Options : # Run FE Tests : : ${FE_TEST:=true} : # Run Backend Tests : : ${BE_TEST:=true} This is a standalone script. People can run this in their development environment, and we run this outside of buildall.sh. Environment variables need to come from bin/impala-config.sh or they need to be optionally set by the user / enclosing script. If coming from the user / enclosing script, there needs to be a default value here. (Also, this script will fail if we try to access an unbound variable.) Separately, it is a bit awkward to expect someone to know to set an environment variable to a particular value for a particular configuration. This is true for some configurations today, but ideally it wouldn't be needed. I think one temporary fix for this is to lump those frontend custom cluster tests in with FE_TEST rather than CLUSTER_TEST for now. FE_TEST already doesn't work on ASAN, so any existing users would have an ok experience. Longer term, it would be nice to detect ASAN correctly. We detect ASAN in our pytests: https://github.com/apache/impala/blob/master/tests/common/environ.py#L141 -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 19 May 2020 23:08:51 +0000 Gerrit-HasComments: Yes
