Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@206 PS4, Line 206: if ! "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae test ${MVN_ARGS}; then I don't think this works - it means that you'll be running the FE custom cluster tests in the same maven run as the rest of the FE tests, but I don't think it's guaranteed that they'll run at the end, so they may interfere with the rest of the FE tests. And we still want the regular FE tests to run against s3. I think you'll need to do two separate calls to mvn-quiet, the first to do the regular FE tests and the second to do the FE custom cluster tests. http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@211 PS4, Line 211: run-step "Starting Impala cluster" start-impala-cluster.log \ You should refactor this out into its own function in this file so that we're not duplicating it -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 28 May 2020 16:44:32 +0000 Gerrit-HasComments: Yes
