Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh@41 PS3, Line 41: # Parametrized Test Options : # Run FE Tests : : ${FE_TEST:=true} : # Run Backend Tests : : ${BE_TEST:=true} > This is a standalone script. People can run this in their development envir Yeah of course, this is happening because we previously required both CLUSTER_TEST and FE_TEST for these to run, so they weren't running in sharded jobs when one shard had CLUSTER_TEST and the other had FE_TEST. I switched it to just require CLUSTER_TEST, but if we instead just require FE_TEST this ASAN issue is fixed. Downsides are that you'll have to have the backend fully built and the minicluster started to run the FE tests, which we didn't used to require but which this script expects anyways, and you'll have to restart impala after these tests run with the same params as on line 166 -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 20 May 2020 16:04:31 +0000 Gerrit-HasComments: Yes
