Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@206 PS4, Line 206: if [[ "$CODE_COVERAGE" == true ]]; then > I don't think this works - it means that you'll be running the FE custom cl Done. http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@211 PS4, Line 211: MVN_ARGS_TEMP=$MVN_ARGS > You should refactor this out into its own function in this file so that we' Done -- To view, visit http://gerrit.cloudera.org:8080/15921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a Gerrit-Change-Number: 15921 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Sat, 30 May 2020 00:22:13 +0000 Gerrit-HasComments: Yes
