Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/16628 )
Change subject: IMPALA-10266: Identify FileSystem type based on the protocol
scheme.
......................................................................
Patch Set 1:
It looks like there are some more instanceof usages sprinkled around the code:
$ git grep 'instanceof.*FileSy'
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: if (!(fs
instanceof DistributedFileSystem) && !(fs instanceof S3AFileSystem) &&
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: !(fs
instanceof AzureBlobFileSystem) &&
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: !(fs
instanceof SecureAzureBlobFileSystem) &&
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: !(fs
instanceof AdlFileSystem) &&
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: !(fs
instanceof OzoneFileSystem)) {
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: boolean
shouldCheckPerms = !(fs instanceof AdlFileSystem ||
fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: fs
instanceof AzureBlobFileSystem || fs instanceof SecureAzureBlobFileSystem);
fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: if
(FileSystemUtil.getDefaultFileSystem() instanceof DistributedFileSystem) {
fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: if
(FileSystemUtil.getDefaultFileSystem() instanceof DistributedFileSystem) {
fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
Preconditions.checkState(fs instanceof DistributedFileSystem);
fe/src/main/java/org/apache/impala/service/JniFrontend.java: if (!(fs
instanceof DistributedFileSystem ||
fe/src/main/java/org/apache/impala/service/JniFrontend.java: fs
instanceof S3AFileSystem ||
fe/src/main/java/org/apache/impala/service/JniFrontend.java: fs
instanceof AzureBlobFileSystem ||
fe/src/main/java/org/apache/impala/service/JniFrontend.java: fs
instanceof SecureAzureBlobFileSystem ||
fe/src/main/java/org/apache/impala/service/JniFrontend.java: fs
instanceof AdlFileSystem)) {
--
To view, visit http://gerrit.cloudera.org:8080/16628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04492326a6e84895eef369fc11a3ec11f1536b6b
Gerrit-Change-Number: 16628
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Oct 2020 17:35:51 +0000
Gerrit-HasComments: No
