Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16628 )
Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@63 PS3, Line 63: private static final Set<String> VALID_SCHEME_FOR_INPATH = Maybe move this to FileSystemUtil? That way all these lists of capabilities would be consolidated. http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@161 PS3, Line 161: + "must point to an HDFS, S3A, ADL, ABFS, or Ozone filesystem.", Can we generate this error message from the list of supported schemes? I think the message would have to change a little to list the schemes instead of these ad-hoc names but it'd be less ambiguous in that case anyway. http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@72 PS3, Line 72: ImmutableSet.<String>builder() I like this pattern! -- To view, visit http://gerrit.cloudera.org:8080/16628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04492326a6e84895eef369fc11a3ec11f1536b6b Gerrit-Change-Number: 16628 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 20:01:59 +0000 Gerrit-HasComments: Yes
