Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16628 )
Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java File fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java: http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@63 PS3, Line 63: Preconditions.checkNotNull(tableName); > Maybe move this to FileSystemUtil? That way all these lists of capabilities Done http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java@161 PS3, Line 161: > Can we generate this error message from the list of supported schemes? I th Done http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/16628/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@72 PS3, Line 72: ImmutableSet.<String>builder() > I like this pattern! Agree, I feel it is easier to understand by grouping them like this. http://gerrit.cloudera.org:8080/#/c/16628/2/fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java File fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java: http://gerrit.cloudera.org:8080/#/c/16628/2/fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java@100 PS2, Line 100: testFsType( > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/16628/2/fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java@186 PS2, Line 186: return "adl://dummy-account.azuredatalakestore.net/dummy-part-3"; > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04492326a6e84895eef369fc11a3ec11f1536b6b Gerrit-Change-Number: 16628 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 21:13:03 +0000 Gerrit-HasComments: Yes
