Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16628 )
Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. ...................................................................... Patch Set 5: Code-Review+2 (1 comment) LGTM. Didn't start precommit yet because it looks like one test will probably fail. http://gerrit.cloudera.org:8080/#/c/16628/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/16628/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@637 PS5, Line 637: public static String getValidLoadDataInpathSchemes() { I think you might need to update AnalyzeStmtsTest to match the error message - i.e. this code. // Source must be HDFS or S3A. AnalysisError(String.format("load data inpath '%s' %s into table " + "tpch.lineitem", "file:///test-warehouse/test.out", overwrite), "INPATH location 'file:/test-warehouse/test.out' must point to an " + "HDFS, S3A, ADL, ABFS, or Ozone filesystem."); -- To view, visit http://gerrit.cloudera.org:8080/16628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04492326a6e84895eef369fc11a3ec11f1536b6b Gerrit-Change-Number: 16628 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Oct 2020 17:23:23 +0000 Gerrit-HasComments: Yes
