Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17834 )
Change subject: IMPALA-10904: Add some perf tools to the repository ...................................................................... Patch Set 2: (1 comment) Thanks for adding the pid option, Zoltan! I tried the script in my machine and it works. Just have one more nit. http://gerrit.cloudera.org:8080/#/c/17834/2/bin/perf_tools/perf-record.sh File bin/perf_tools/perf-record.sh: http://gerrit.cloudera.org:8080/#/c/17834/2/bin/perf_tools/perf-record.sh@79 PS2, Line 79: perf_all.svg Since the script name changed, should the output file name change as well? -- To view, visit http://gerrit.cloudera.org:8080/17834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3da696b939204d23c5285dcf1bf6ee3a3738415 Gerrit-Change-Number: 17834 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Sep 2021 22:16:27 +0000 Gerrit-HasComments: Yes
