Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17834 )
Change subject: IMPALA-10904: Add some perf tools to the repository ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17834/4/bin/perf_tools/perf-query.sh File bin/perf_tools/perf-query.sh: http://gerrit.cloudera.org:8080/#/c/17834/4/bin/perf_tools/perf-query.sh@48 PS4, Line 48: echo "Please use 'git clone https://github.com/brendangregg/FlameGraph' in ${IMPALA_TOOLCHAIN}" line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17834/4/bin/perf_tools/perf-record.sh File bin/perf_tools/perf-record.sh: http://gerrit.cloudera.org:8080/#/c/17834/4/bin/perf_tools/perf-record.sh@41 PS4, Line 41: echo "Please use 'git clone https://github.com/brendangregg/FlameGraph' in ${IMPALA_TOOLCHAIN}" line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3da696b939204d23c5285dcf1bf6ee3a3738415 Gerrit-Change-Number: 17834 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Sep 2021 16:12:48 +0000 Gerrit-HasComments: Yes