Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17834 )

Change subject: IMPALA-10904: Add some perf tools to the repository
......................................................................


Patch Set 3:

(1 comment)

Thanks for trying out the scripts!

http://gerrit.cloudera.org:8080/#/c/17834/2/bin/perf_tools/perf-record.sh
File bin/perf_tools/perf-record.sh:

http://gerrit.cloudera.org:8080/#/c/17834/2/bin/perf_tools/perf-record.sh@79
PS2, Line 79: perf_record.
> Since the script name changed, should the output file name change as well?
Thanks for catching this! Done.



--
To view, visit http://gerrit.cloudera.org:8080/17834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3da696b939204d23c5285dcf1bf6ee3a3738415
Gerrit-Change-Number: 17834
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 08:54:27 +0000
Gerrit-HasComments: Yes

Reply via email to