wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18099 )
Change subject: IMPALA-11049: Substitute order by elements when creating SortInfo ...................................................................... Patch Set 2: (5 comments) Thanks for review! http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG@12 PS1, Line 12: causes Anal > nit: causes Done http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG@13 PS1, Line 13: type because > Maybe it's worth to mention that they are INVALID type because they weren't Done http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG@15 PS1, Line 15: ts_' in-place, and : use these substituted exprs to create 'SortInfo'. B > I think we are already printing out the rewritten query in explain. E.g. fo Done http://gerrit.cloudera.org:8080/#/c/18099/1//COMMIT_MSG@17 PS1, Line 17: : > nit: to ensure that exprs are already analyzed. Done http://gerrit.cloudera.org:8080/#/c/18099/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java: http://gerrit.cloudera.org:8080/#/c/18099/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java@61 PS1, Line 61: econditions.checkState(castExpr.getType( > 'castExpr' must be analyzed before rewrite. Maybe we could add this as an e Done -- To view, visit http://gerrit.cloudera.org:8080/18099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Gerrit-Change-Number: 18099 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 15 Dec 2021 15:57:07 +0000 Gerrit-HasComments: Yes
