Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18099 )
Change subject: IMPALA-11049: Substitute order by elements when creating SortInfo ...................................................................... Patch Set 5: I think it's not guaranteed that exprs used in rewrite rules are all analyzed. So we have codes like this to analyze exprs in time: https://github.com/apache/impala/blob/200d3664f0117e1f7a9b01941d004189d4343920/fe/src/main/java/org/apache/impala/rewrite/ConvertToCNFRule.java#L114-L118 I'll run a GVO to see how many tests required changes due to the EXPLAIN difference. -- To view, visit http://gerrit.cloudera.org:8080/18099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2780e04a6d5a32e224cd0470cf6f166a832363ec Gerrit-Change-Number: 18099 Gerrit-PatchSet: 5 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 12 Jan 2022 11:40:54 +0000 Gerrit-HasComments: No
