Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 )
Change subject: IMPALA-11063: Add metrics to expose state of each executor group set ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM, see small worry http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@64 PS1, Line 64: static const string LIVE_EXEC_GROUP_KEY_FORMAT( Nit: This is not incorrect, but "cluster-membership.executor-groups.total.$0" shares a prefix with "cluster-membership.executor-groups.total" and that's the sort of thing that could tickle autoscaler bugs where code uses prefixes to fetch metrics. http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/18142/1/tests/custom_cluster/test_executor_groups.py@134 PS1, Line 134: metric_name += "." + exec_group_set_prefix This is where the code I marked with a Nit is actually useful -- To view, visit http://gerrit.cloudera.org:8080/18142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f940de830ef6302785aee30eeb847fa5deeba Gerrit-Change-Number: 18142 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Jan 2022 18:04:18 +0000 Gerrit-HasComments: Yes
