Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 )
Change subject: IMPALA-11063: Add metrics to expose state of each executor group set ...................................................................... Patch Set 1: (4 comments) Looks good to me. http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.h@248 PS1, Line 248: overall_group_metrics_ nit. May name it as overall_group_set_metrics_ to keep it consistent with per_group_set_metrics_. http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@89 PS1, Line 89: overall_group_metrics_.total_live_executor_groups_ = : metric_grp->AddCounter(LIVE_EXEC_GROUP_KEY, 0); : overall_group_metrics_.total_healthy_executor_groups_ = : metric_grp->AddCounter(HEALTHY_EXEC_GROUP_KEY, 0); : overall_group_metrics_.total_backends_ = metric_grp->AddCounter(TOTAL_BACKENDS_KEY, 0); nit.these lines of code can be moved to a method GroupSetMetrics::Add(MetricGroup) http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@606 PS1, Line 606: group.IsHealthy() I wonder if there is a method ExecutorGroup::isLive(). If so, it can be useful to manipulate total_live_exec_groups. http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@611 PS1, Line 611: ++total_live_exec_groups; : total_backends += group.NumExecutors(); nit. duplicated lines with the THEN branch. -- To view, visit http://gerrit.cloudera.org:8080/18142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f940de830ef6302785aee30eeb847fa5deeba Gerrit-Change-Number: 18142 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Jan 2022 20:23:37 +0000 Gerrit-HasComments: Yes
