Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 )
Change subject: IMPALA-11063: Add metrics to expose state of each executor group set ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@89 PS1, Line 89: MetricGroup* metric_grp = metrics->GetOrCreateChildGroup("cluster-membership"); : aggregated_group_set_metrics_.total_live_executor_groups_ = : metric_grp->AddCounter(LIVE_EXEC_GROUP_KEY, 0); : aggregated_group_set_metrics_.total_healthy_executor_groups_ = : metric_grp->AddCounter(HEALTHY_EXEC_GROUP_KEY, 0); > The keys and inputs to AddCounter() are different for 'overall' vs 'per_gro Done http://gerrit.cloudera.org:8080/#/c/18142/1/be/src/scheduling/cluster-membership-mgr.cc@606 PS1, Line 606: ngPiece name(grou > group.NumHosts() > 0 is the only simple check we need unlike IsHealthy() wh Done -- To view, visit http://gerrit.cloudera.org:8080/18142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib39f940de830ef6302785aee30eeb847fa5deeba Gerrit-Change-Number: 18142 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Jan 2022 00:09:02 +0000 Gerrit-HasComments: Yes
