Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 )
Change subject: IMPALA-11123: Optimize count(star) for ORC scans ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18327/2/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/18327/2/tests/query_test/test_aggregation.py@279 PS2, Line 279: if (vector.get_value('table_format').file_format != 'text' or : vector.get_value('table_format').compression_codec != 'none'): > This test constraint, along with parquet and kudu ones, is a bit misleading Looking again, the core exploration of this test only have single 'text/none' format dimension (create_uncompressed_text_dimension in line 183). Therefore, this misleading constraint is needed to execute the test just two times (codegen vs non-codegen), even in exhaustive exploration. -- To view, visit http://gerrit.cloudera.org:8080/18327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fafa1182f97323aeb9ee39dd4e8ecd418fa6091 Gerrit-Change-Number: 18327 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Mar 2022 18:12:55 +0000 Gerrit-HasComments: Yes
