Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 )
Change subject: IMPALA-11123: Optimize count(star) for ORC scans ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Looks very good! http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.h File be/src/exec/hdfs-orc-scanner.h: http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.h@435 PS3, Line 435: Handles count(*) queries, writing only nit. Handle count(*) queries by reading the row count http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18327/3/be/src/exec/hdfs-orc-scanner.cc@806 PS3, Line 806: GetNextWithCountStarOptimization Very cool! http://gerrit.cloudera.org:8080/#/c/18327/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/18327/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@406 PS2, Line 406: se; > Currently full acid table only available with ORC. But it looks like Parque Done http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test: http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test@22 PS3, Line 22: aggregation(SUM, NumRowGroups): 0 nit. Can you please explain why there is the change? -- To view, visit http://gerrit.cloudera.org:8080/18327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fafa1182f97323aeb9ee39dd4e8ecd418fa6091 Gerrit-Change-Number: 18327 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Mar 2022 22:37:50 +0000 Gerrit-HasComments: Yes
