Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 )
Change subject: IMPALA-11123: Optimize count(star) for ORC scans ...................................................................... Patch Set 4: (1 comment) Patch set 4 is a rebase http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test: http://gerrit.cloudera.org:8080/#/c/18327/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-upper-lower-bound-metrics.test@22 PS3, Line 22: aggregation(SUM, NumRowGroups): 0 > nit. Can you please explain why there is the change? Previously, we are still iterating row groups and read stripe stats to serve count(star). Patch set 3 change this by reading footer stats only. Hence, NumRowGroups now becomes 0 because we're iterating none of it. -- To view, visit http://gerrit.cloudera.org:8080/18327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fafa1182f97323aeb9ee39dd4e8ecd418fa6091 Gerrit-Change-Number: 18327 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 03:57:43 +0000 Gerrit-HasComments: Yes
