Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18819 )
Change subject: IMPALA-11436: Change search bind authentication parameters ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18819/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18819/1//COMMIT_MSG@14 PS1, Line 14: For user search, Spring uses {0} to replace the login username. : Meanwhile, during group search {0} is used to replace the login user dn : and {1} is used to replace the login username. > Yes, unfortunately this can break running systems, but the identification o I am ok with not adding more complexity to the code and warn about this in the release notes. Can you also update the documentation? https://github.com/apache/impala/blob/master/docs/topics/impala_ldap.xml#L478 I am not sure whether we usually do it in the same commit or a different one. -- To view, visit http://gerrit.cloudera.org:8080/18819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9808566a348f7c6200b0571fbc05e67f720f2075 Gerrit-Change-Number: 18819 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Thu, 11 Aug 2022 12:33:24 +0000 Gerrit-HasComments: Yes
