Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18819 )
Change subject: IMPALA-11436: Change search bind authentication parameters ...................................................................... IMPALA-11436: Change search bind authentication parameters Impala's search bind authentication intends to mimic Spring's behaviour. However, the login username and user dn paremeters were swapped for group searches compared to Spring. This change intends to align these parameters. For user search, Spring uses {0} to replace the login username. Meanwhile, during group search {0} is used to replace the login user dn and {1} is used to replace the login username. Testing: - Ran LdapSearchBindImpalaShellTest frontend tests Change-Id: I9808566a348f7c6200b0571fbc05e67f720f2075 Reviewed-on: http://gerrit.cloudera.org:8080/18819 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/util/ldap-search-bind.cc M docs/topics/impala_ldap.xml M fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java 3 files changed, 30 insertions(+), 23 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9808566a348f7c6200b0571fbc05e67f720f2075 Gerrit-Change-Number: 18819 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org>