Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18819 )
Change subject: IMPALA-11436: Change search bind authentication parameters ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18819/3/docs/topics/impala_ldap.xml File docs/topics/impala_ldap.xml: http://gerrit.cloudera.org:8080/#/c/18819/3/docs/topics/impala_ldap.xml@484 PS3, Line 484: The <codeph>{0}</codeph> and <codeph>{1}</codeph> patterns have been swapped : between 4.1 and 4.2 releases. Thank you for the review! No worries, I am happy to make it as clear as possible. > The description above should contain the new behavior. > The note should contain that it was swapped, and what was the old behavior. Done, explained it more clearly with previous and current behaviours. > The Jira id could be mentioned for people who want more info on topic. I wanted to avoid adding Jira IDs to the docs and the Jira description is short, so added the key point to this note. -- To view, visit http://gerrit.cloudera.org:8080/18819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9808566a348f7c6200b0571fbc05e67f720f2075 Gerrit-Change-Number: 18819 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Fri, 19 Aug 2022 08:47:14 +0000 Gerrit-HasComments: Yes
