Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 )
Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables ...................................................................... Patch Set 4: (3 comments) Went through the code quickly. My main concern is that it always migrates to a 'hadoop.tables' catalog and would be good if we could be more flexible about this. And if we can, HiveCatalog would be a better default. http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG@23 PS4, Line 23: not temporary tables What do you mean by 'temporary table'? In Impala we don't support such tables. http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG@30 PS4, Line 30: querie nit: query http://gerrit.cloudera.org:8080/#/c/19397/4/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/19397/4/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@71 PS4, Line 71: IcebergHadoopTables.createTable Would it be possible to use Iceberg's Catalogs API? https://github.com/apache/iceberg/blob/ce6c95025d33aac663ecdfb99ff92f2d71731263/mr/src/main/java/org/apache/iceberg/mr/Catalogs.java#L151 This way the user could specify any Iceberg catalog. And our default catalog could be Hive Catalog, which is the Catalog being used for plain CREATE TABLE STORED AS ICEBERG statements already. -- To view, visit http://gerrit.cloudera.org:8080/19397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e6a9cfe099c263f17b5506d6db459b79ad31a5 Gerrit-Change-Number: 19397 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Jan 2023 17:06:55 +0000 Gerrit-HasComments: Yes
