lipeng...@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 )
Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables ...................................................................... Patch Set 6: (3 comments) I fix the migrated Iceberg tables should be Hive Catalog by default. This is a big patch, thanks for comments! http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG@23 PS4, Line 23: s tables must follow > What do you mean by 'temporary table'? In Impala we don't support such tabl https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-TemporaryTables I noticed that hive supports this type table, so I added this logic, which seems to be omitted! http://gerrit.cloudera.org:8080/#/c/19397/4//COMMIT_MSG@30 PS4, Line 30: query > nit: query Done http://gerrit.cloudera.org:8080/#/c/19397/4/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java File fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java: http://gerrit.cloudera.org:8080/#/c/19397/4/fe/src/main/java/org/apache/impala/util/MigrateTableUtil.java@71 PS4, Line 71: > Would it be possible to use Iceberg's Catalogs API? It was a flaw in my design, and I fixed it. We should migrate to Hive Catalog by default. -- To view, visit http://gerrit.cloudera.org:8080/19397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e6a9cfe099c263f17b5506d6db459b79ad31a5 Gerrit-Change-Number: 19397 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Jan 2023 11:22:18 +0000 Gerrit-HasComments: Yes
