Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19397 )
Change subject: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables ...................................................................... Patch Set 6: (3 comments) This seems a very useful change. I have a few general comments/questions. http://gerrit.cloudera.org:8080/#/c/19397/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19397/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-11013 (part 1): Support 'MIGRATE TABLE' for external Hdfs tables I know what you mean by an "Hdfs table" but maybe "Hive table" is clearer. Our new table will still be in hdfs, it will just have a different table format. http://gerrit.cloudera.org:8080/#/c/19397/6//COMMIT_MSG@14 PS6, Line 14: tables. Is it it true to say "the data files themselves are not changed during this migration". If so it would be nice to state this explicitly. http://gerrit.cloudera.org:8080/#/c/19397/6//COMMIT_MSG@35 PS6, Line 35: - Child query 4: Drop the temporary Hdfs table. > What happens if there is an error at any step? It would be nice if we could I read that in Spark "When you migrate a Hive table to Iceberg, a backup of the table, named <table_name>backup, is created." That could be a nice feature which might be easy to implement. Of course this could be deferred to future work. -- To view, visit http://gerrit.cloudera.org:8080/19397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e6a9cfe099c263f17b5506d6db459b79ad31a5 Gerrit-Change-Number: 19397 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jan 2023 02:26:34 +0000 Gerrit-HasComments: Yes
