Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 )
Change subject: IMPALA-11856: Use POST requests to set log level ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/19199/15/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/19199/15/be/src/util/webserver.cc@703 PS15, Line 703: LOG(INFO) << "Inv > This is a relocation of lines 665-667. It didn't have a comment before; I'l I think I get it now - what confused me was the handling of AuthMode::HTPASSWD. In that case the authentication is handled by Squeasel based on a password file, so I guess we won't even get here if the password was wrong. If it was correct, then it is true that the authentication is finished. and the cookie should be added / checked. I still think that the code is quite confusing, but I don't mind if it is kept as it is. -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Jan 2023 13:43:33 +0000 Gerrit-HasComments: Yes
