Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 )
Change subject: IMPALA-11856: Use POST requests to set log level ...................................................................... Patch Set 19: Code-Review+1 (3 comments) Went through the tests too, looks great! http://gerrit.cloudera.org:8080/#/c/19199/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19199/19//COMMIT_MSG@11 PS19, Line 11: where POST requests must include a : csrf_token field in their post with the random value from the cookie - : or a custom header. This means that POST requests will always need csrf_token or X-requested-by, even if it is not POST with side-effects (e.g. changing logs, just reading a page), right? Is it possible that some tools query the Impala webui with POST while they could use GET? http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java: http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@414 PS19, Line 414: does nothing This also returns an error like the previous block, right? http://gerrit.cloudera.org:8080/#/c/19199/19/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@425 PS19, Line 425: new WebClient(TEST_USER_1, TEST_PASSWORD_1); just an idea to reduce noise: WebClient could have a reset function or a resetAfterRequest property that leads to dropping cookies + opening new connection -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 19 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Jan 2023 08:16:28 +0000 Gerrit-HasComments: Yes
