Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 )
Change subject: IMPALA-11856: Use POST requests to set log level ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/19199/20/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java: http://gerrit.cloudera.org:8080/#/c/19199/20/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@475 PS20, Line 475: * Test that we can set glog level. > Nit: java log level Ack http://gerrit.cloudera.org:8080/#/c/19199/20/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@563 PS20, Line 563: assertTrue("Expected cookie to contain random number", false); > Nit: or just use fail() Ack http://gerrit.cloudera.org:8080/#/c/19199/20/fe/src/test/java/org/apache/impala/testutil/WebClient.java File fe/src/test/java/org/apache/impala/testutil/WebClient.java: http://gerrit.cloudera.org:8080/#/c/19199/20/fe/src/test/java/org/apache/impala/testutil/WebClient.java@107 PS20, Line 107: * @param data Parameters to include in the POST > Nit: I know you are just copying code but this parameter is wrong Just an earlier version of my function. -- To view, visit http://gerrit.cloudera.org:8080/19199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4be8694492b8ba16737f644ac8c56d8124f19693 Gerrit-Change-Number: 19199 Gerrit-PatchSet: 20 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Jan 2023 21:32:36 +0000 Gerrit-HasComments: Yes
