Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins ...................................................................... Patch Set 20: Code-Review+1 (6 comments) Looks pretty good. I still have a few things I think would be worth cleaning up. http://gerrit.cloudera.org:8080/#/c/19425/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19425/18//COMMIT_MSG@31 PS18, Line 31: Known limitations: > https://issues.apache.org/jira/browse/IMPALA-11889 created Done http://gerrit.cloudera.org:8080/#/c/19425/18/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/19425/18/be/src/exprs/hive-udf-call.cc@195 PS18, Line 195: bool builtin_udf = fn_.hdfs_location.empty(); > Before this patch Impala has assumed that all Hive UDFs come for external j I'd feel more comfortable with a code comment describing the expectations here. http://gerrit.cloudera.org:8080/#/c/19425/18/be/src/kudu/rpc/CMakeLists.txt File be/src/kudu/rpc/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19425/18/be/src/kudu/rpc/CMakeLists.txt@110 PS18, Line 110: add_dependencies(protoc-gen-krpc thrift-deps) > Removed. Oh, it was because the executable links global-flags.cc. And I guess types.h can't be included without the library. http://gerrit.cloudera.org:8080/#/c/19425/20/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/19425/20/bin/start-impala-cluster.py@431 PS20, Line 431: args = "{args} -geospatial_library {geospatial_library}".format( Why did this change? http://gerrit.cloudera.org:8080/#/c/19425/18/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java File fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java: http://gerrit.cloudera.org:8080/#/c/19425/18/fe/src/test/java/org/apache/impala/hive/executor/TestHiveJavaFunctionFactory.java@32 PS18, Line 32: return extract(new HiveLegacyFunctionExtractor()); > I don't really understand what override removing means in this context, I r I meant you could remove this version of the signature from TestHiveJavaFunction. The original would work just as well. I think explicitly re-implementing https://gerrit.cloudera.org/c/19425/20/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java#89 is more confusing. http://gerrit.cloudera.org:8080/#/c/19425/18/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/19425/18/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@1 PS18, Line 1: ===== > These tests are coming from https://github.com/Esri/spatial-framework-for-h What's here seems fine. -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 20 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Feb 2023 17:39:42 +0000 Gerrit-HasComments: Yes
