Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins ...................................................................... Patch Set 22: (2 comments) Looks good, just a few things. http://gerrit.cloudera.org:8080/#/c/19425/22/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/22/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java@46 PS22, Line 46: Nit: -2 indentation. http://gerrit.cloudera.org:8080/#/c/19425/22/fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java File fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java: http://gerrit.cloudera.org:8080/#/c/19425/22/fe/src/test/java/org/apache/impala/hive/executor/HiveLegacyJavaFunctionTest.java@151 PS22, Line 151: dummyudffn Can we generate the expected name here the same way the actual name is generated? -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 22 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 13:12:35 +0000 Gerrit-HasComments: Yes
