Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19425 )
Change subject: IMPALA-11745: Add Hive's ESRI geospatial functions as builtins ...................................................................... Patch Set 22: (3 comments) http://gerrit.cloudera.org:8080/#/c/19425/20/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/19425/20/bin/start-impala-cluster.py@431 PS20, Line 431: args = "{args} -geospatial_library={geospatial_library}".format( > Why did this change? Restored to the {}={} pattern, I got confused about which argument passing format is used here http://gerrit.cloudera.org:8080/#/c/19425/21/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/21/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@88 PS21, Line 88: public List<ScalarFunction> extract(HiveLegacyFunctionExtractor extractor) > nit: not needed because the interface provides a default. Done http://gerrit.cloudera.org:8080/#/c/19425/21/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/19425/21/fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunction.java@44 PS21, Line 44: public default List<ScalarFunction> extract() throws CatalogException { > Oh, I think I missed that they were all implementing an interface rather th Done -- To view, visit http://gerrit.cloudera.org:8080/19425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0ca02a70b4ba244778c9db6d14df4423072b225 Gerrit-Change-Number: 19425 Gerrit-PatchSet: 22 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Feb 2023 08:24:21 +0000 Gerrit-HasComments: Yes
