Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )
Change subject: IMPALA-11509: Prevent query hanging when Iceberg metadata is missing. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19509/2//COMMIT_MSG@15 PS2, Line 15: StmtMetadataLoader.loadTables() waits hopefully > I am no expert on StmtTableCache.loadTables(). Having an infinite loop does Cancel the query, alert the user that's something is wrong with that particular tables metadata, so it can be investigated. My problem is not with the passiveness of the loop, what I don't like is the Coordinator responsiveness depends on another process' state. I think it's the Coordinators responsibility to make sure it does not get stuck in any case. http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/19509/2/fe/src/main/java/org/apache/impala/catalog/Table.java@549 PS2, Line 549: newTable.validate(); > Yes you’re right, that could happen. I suppose that mismatched columns is a I don't mind narrowing down the scope for iceberg specific case, and yes I agree, throwing from .validate() is much more serious, probably should be handled differently -- To view, visit http://gerrit.cloudera.org:8080/19509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421 Gerrit-Change-Number: 19509 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Feb 2023 08:39:37 +0000 Gerrit-HasComments: Yes
