Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )
Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. ...................................................................... Patch Set 4: (2 comments) Thanks for the review http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java@544 PS4, Line 544: e); > nit: putting this into new line seems a bit odd. That's what clang-format seems to want :-) But I agree and have changed it. http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145 PS4, Line 145: def test_drop_corrupt_table(self, unique_database): > About testing this: I remember when I ran into this issue, I had to turn of The good news is that test_drop_incomplete_table runs... (I did not stress test) The bads new is that it consistently fails with Query aborted:TableNotFoundException: Table 'test_drop_incomplete_table_8548cb55.synchronized_iceberg_tbl' does not exist in Iceberg catalog. Maybe we need to just never throw the TableNotFoundException in IcebergCatalogOpExecutor.dropTable() -- To view, visit http://gerrit.cloudera.org:8080/19509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421 Gerrit-Change-Number: 19509 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 04 Mar 2023 01:45:58 +0000 Gerrit-HasComments: Yes