Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )
Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. ...................................................................... Patch Set 4: (2 comments) Thanks for taking care of this, Andrew! http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/19509/4/fe/src/main/java/org/apache/impala/catalog/Table.java@544 PS4, Line 544: e); nit: putting this into new line seems a bit odd. http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145 PS4, Line 145: def test_drop_corrupt_table(self, unique_database): About testing this: I remember when I ran into this issue, I had to turn off a test until we have a fix. Would be great if we could turn it on again. It was 'test_drop_incomplete_table', here: https://gerrit.cloudera.org/#/c/18837/10/tests/query_test/test_iceberg.py This test sporadically got into infinite loop if I remember right, so might need few runs to reproduce the issue. -- To view, visit http://gerrit.cloudera.org:8080/19509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421 Gerrit-Change-Number: 19509 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Mar 2023 11:22:48 +0000 Gerrit-HasComments: Yes
