Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile if the query failed in planning ...................................................................... Patch Set 1: (3 comments) Thank you Baike Xia, this is an important improvement. http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@7 PS1, Line 7: Nit: unnecessary double space. http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@9 PS1, Line 9: Failed to call RunFrontendPlanner, in profile, add: Could you clarify the commit message? - It is not clear from the description that query options are normally already included in the profile and the problem is that they are missing if the query fails in planning - first I mistakenly thought that we only want to include query options if the query fails in planning. Maybe using the title of the Jira ("Query options are missing in the profile if the query failed in planning") would be a good idea. - Do you mean that if the call to RunFrontendPlanner() fails, we should still list the query options that are set by configuration, and if the query fails after planning we should list the query options set by configuration and the planner? If so, we could mention, as in the Jira, what are the two lines about query options that are normally included in the profile (see the Jira ticket for the example). http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@13 PS1, Line 13: Can we add tests that verify that the query options are included in the profile even in the case of planning failure? -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 1 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Feb 2023 14:58:51 +0000 Gerrit-HasComments: Yes
