Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile if the query failed in planning ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@13 PS1, Line 13: Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 > Sorry, I can't. I tried to add the relevant tests, but couldn't find where One place where this could go is tests/query_test/test_observability.py. You can take 'test_merge_exchange_num_rows()' as an example of how to run a query and retrieve its runtime profile. I'd suggest to use another test query than the one in the Jira because structs containing collections are expected to become supported in the near future. We could for example try to access a non-existent table to provoke a planning failure. http://gerrit.cloudera.org:8080/#/c/19517/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/2//COMMIT_MSG@7 PS2, Line 7: profile if "... profile even if ..." would be clearer in my opinion. http://gerrit.cloudera.org:8080/#/c/19517/2//COMMIT_MSG@9 PS2, Line 9: should usually be "are normally included in the profile" would be better. http://gerrit.cloudera.org:8080/#/c/19517/2//COMMIT_MSG@10 PS2, Line 10: Query No need to capitalise "query"; see also the other "Query" on this line. http://gerrit.cloudera.org:8080/#/c/19517/2//COMMIT_MSG@11 PS2, Line 11: Upon failure, should add query options to the profile. It could be something like: "After this change, query options are also added to the profile upon planning failure." -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 24 Feb 2023 13:23:39 +0000 Gerrit-HasComments: Yes
