Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 )
Change subject: IMPALA-11898: Add query options in the profile if the query failed in planning ...................................................................... Patch Set 2: (3 comments) Hi Daniel, Thank you for your reply and suggestions. http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@7 PS1, Line 7: i > Nit: unnecessary double space. Done http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@9 PS1, Line 9: Query options should usually be in the profile, > Could you clarify the commit message? Yeah, just like the jira title, query options should usually be in the profile, but when the Query fails during planning, Query options are missing. The RunFrontendPlanner method is used for planning. Failure here should add query options. e.g.: Query Options (set by configuration): TIMEZONE=PRC,CLIENT_IDENTIFIER=impala shell build version not available. If the query fails after planning we should list the query options set by configuration and the planner. e.g.: Query Options (set by configuration): TIMEZONE=PRC,CLIENT_IDENTIFIER=impala shell build version not available Query Options (set by configuration and planner): MT_DOP=0,TIMEZONE=PRC,CLIENT_IDENTIFIER=impala shell build version not available,MINMAX_FILTER_THRESHOLD=0.5,MINMAX_FILTERING_LEVEL=PAGE http://gerrit.cloudera.org:8080/#/c/19517/1//COMMIT_MSG@13 PS1, Line 13: Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 > Can we add tests that verify that the query options are included in the pro Sorry, I can't. I tried to add the relevant tests, but couldn't find where to add them. Can you tell me? -- To view, visit http://gerrit.cloudera.org:8080/19517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ce62008dd5b1671b09eda5365cbb0940ebe64 Gerrit-Change-Number: 19517 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Feb 2023 08:44:46 +0000 Gerrit-HasComments: Yes
