Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 )
Change subject: IMPALA-11223: Use unique id to create codegen instances ...................................................................... Patch Set 1: Thanks Quanlong, this seems good to me. I wonder if this solves a problem I've come across a few times in the past: when I was looking for a codegen'd function in the unoptimised llvm bitcode, sometimes when I ran the same query several times, the function only showed up in about 1 case out of 5. Do you think it's possible that the output file was overwritten by another fragment? Or is this change only relevant for the asm output? -- To view, visit http://gerrit.cloudera.org:8080/19505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31 Gerrit-Change-Number: 19505 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 23 Feb 2023 10:31:04 +0000 Gerrit-HasComments: No
