Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/19505 )
Change subject: IMPALA-11223: Use unique id to create codegen instances
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+1
>
> LGTM!
> Because it changes the id of the LlvmCodeGen, just to confirm do you know is
> there any other place also needs the id?
I think the only other place that uses this id is 'fn_symbol' generated in
CodegenSymbolEmitter:
// Append id to symbol to disambiguate different instances of jitted
functions.
string fn_symbol = Substitute("$0:$1", name_or_err.get().data(), id_);
It's used to dump the disassembly when asm_module_dir is set. The new id still
meets the requirement of uniqueness.
https://github.com/apache/impala/blob/6ebf35cd5d9d8762147b73bd99b53fd2ffc426d3/be/src/codegen/codegen-symbol-emitter.cc#L109
--
To view, visit http://gerrit.cloudera.org:8080/19505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31
Gerrit-Change-Number: 19505
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 07:57:58 +0000
Gerrit-HasComments: No
