Hello Daniel Becker, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19505
to look at the new patch set (#3).
Change subject: IMPALA-11223: Use unique id to create codegen instances
......................................................................
IMPALA-11223: Use unique id to create codegen instances
When startup flag asm_module_dir is set, impalad will dump the codegen
disassembly to files under that folder. The file name is "id.asm" in
which "id" is the codegen instance id. Before IMPALA-4080 (f2837e9), we
used fragment instance id as the codegen id. After that, since codegen
is done in fragment level (shared by fragment instances), we use query
id instead. This introduces conflicts between different fragments. The
asm files will be overwritten.
The same conflict happens in dumping IR modules (when unopt_module_dir
or opt_module_dir is set).
This changes the codegen instance id to be "QueryID_FragmentName_PID".
The PID suffix is needed since we usually have several impalads running
together on our dev box.
Tests:
- Manually verified the asm file names are expected.
Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31
---
M be/src/runtime/fragment-state.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/19505/3
--
To view, visit http://gerrit.cloudera.org:8080/19505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31
Gerrit-Change-Number: 19505
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
