Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 )
Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19533/6/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/19533/6/be/src/scheduling/admission-controller.cc@1111 PS6, Line 1111: } else if (be_state.be_desc.admit_mem_limit() < min_executor_admit_mem_limit.second) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19533/6/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/19533/6/tests/custom_cluster/test_admission_controller.py@700 PS6, Line 700: + flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/19533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1f6e530785ef832dbc831d7cc6793133f3335c Gerrit-Change-Number: 19533 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:46:35 +0000 Gerrit-HasComments: Yes
