Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 )
Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19533/4/be/src/scheduling/executor-group.cc File be/src/scheduling/executor-group.cc: http://gerrit.cloudera.org:8080/#/c/19533/4/be/src/scheduling/executor-group.cc@100 PS4, Line 100: if (per_executor_admit_mem_limit_ > 0) { : per_executor_admit_mem_limit_ = : std::min(be_desc.admit_mem_limit(), per_executor_admit_mem_limit_); : } else if (per_executor_admit_mem_limit_ == 0) { : per_executor_admit_mem_limit_ = be_desc.admit_mem_limit(); : } else { : DCHECK(false) << "Invalid negative value of per_executor_admit_mem_limit_ " : << per_executor_admit_mem_limit_; : } > I see. Done. be_desc.admit_mem_limit() must be greater than 0. -- To view, visit http://gerrit.cloudera.org:8080/19533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1f6e530785ef832dbc831d7cc6793133f3335c Gerrit-Change-Number: 19533 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 06 Mar 2023 00:46:31 +0000 Gerrit-HasComments: Yes
