Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19533 )
Change subject: IMPALA-11858: Cap per backend memory estimate to its memory limit for admission ...................................................................... Patch Set 7: Code-Review+1 (3 comments) I've read through and this looks good http://gerrit.cloudera.org:8080/#/c/19533/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19533/7//COMMIT_MSG@9 PS7, Line 9: admission controller caps memory estimates for a given query to Nit: Admission http://gerrit.cloudera.org:8080/#/c/19533/7/be/src/scheduling/schedule-state.h File be/src/scheduling/schedule-state.h: http://gerrit.cloudera.org:8080/#/c/19533/7/be/src/scheduling/schedule-state.h@288 PS7, Line 288: /// admitted based on the pool configuration passed to it. Must be called at least once Nit: update the comment to cover the new parameters http://gerrit.cloudera.org:8080/#/c/19533/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/19533/7/tests/custom_cluster/test_admission_controller.py@504 PS7, Line 504: # A bit too much memory to run on coordinator. mem_limit will be clamped Are we losing coverage on the "A bit too much memory to run on coordinator" case? I suppose we could ruin with -clamp_query_mem_limit_backend_mem_limit=false to get the old behavior. -- To view, visit http://gerrit.cloudera.org:8080/19533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b1f6e530785ef832dbc831d7cc6793133f3335c Gerrit-Change-Number: 19533 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 08 Mar 2023 01:16:00 +0000 Gerrit-HasComments: Yes
