Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/19509 )
Change subject: IMPALA-11509: Prevent queries hanging when Iceberg metadata is missing. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19509/4/tests/query_test/test_iceberg.py@145 PS4, Line 145: def test_drop_corrupt_table(self, unique_database): > The good news is that test_drop_incomplete_table runs... I'm a bit rusty with this part of the code but I'm wondering what the outcome of this failing test is. I mean is it still visible from Impala as a valid table? "Test DROP TABLE when the underlying directory is deleted. In that case table loading fails, but we should be still able to drop the table from Impala." I guess if we end up dropping the table from Impala's perspective (from the file system is already dropped so I guess we have to make sure that the catalog/HMS part is also dropped) then we are fine. We might want to swallow that exception, though. -- To view, visit http://gerrit.cloudera.org:8080/19509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695559e21c510615918a51a4b5057bc616ee5421 Gerrit-Change-Number: 19509 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:44:38 +0000 Gerrit-HasComments: Yes
