Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19893 )
Change subject: IMPALA-12145: Fix profiles with non-ascii character in impala-shell (python2) ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19893/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/19893/1/shell/impala_shell.py@1144 PS1, Line 1144: query_profile_prefix = query_profile_prefix.encode('utf-8') > I'm concerned that this is just one case impacted by using unicode_literals It looks like our current version of Thrift generates python that returns RPC results as byte strings. Should we convert all RPC results to unicode? Or patch literals that might be concatenated with RPC results so they're byte strings in Python 2 and unicode in Python 3? That partially defeats the point of setting unicode_literal. -- To view, visit http://gerrit.cloudera.org:8080/19893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b72dd262fc7c382e8baee1dce7592880c84de2 Gerrit-Change-Number: 19893 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 16 May 2023 16:35:38 +0000 Gerrit-HasComments: Yes
